🔄 Sync supportpal/addon-language-english#12
Open
bytestream wants to merge 1 commit intomasterfrom
Open
Conversation
bytestream
force-pushed
the
sync
branch
3 times, most recently
from
f9bf070 to
0246b55
Compare
There was a problem hiding this comment.
Pull request overview
This PR synchronizes language files and GitHub Actions workflows from the English language addon repository. The changes primarily reorganize translation strings and update CI/CD dependencies.
- Reorganizes the
published_desctranslation key in the Spanish selfservice language file to a new version section (5.7.5) - Adds a new translation key
not_published(currently untranslated) - Fixes string interpolation syntax in core.php by removing an unnecessary backslash
- Updates GitHub Actions checkout action from v4 to v5 across workflow files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Lang/es/selfservice.php | Moves published_desc key to version 5.7.5 section and adds new not_published key (needs Spanish translation) |
| Lang/es/core.php | Fixes string interpolation by removing unnecessary backslash escape before ${count} variable |
| .github/workflows/test.yml | Updates actions/checkout from v4 to v5 in two locations |
| .github/workflows/release.yml | Updates actions/checkout from v4 to v5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "comment_notification" => "Nuevo comentario publicado", | ||
| "comment_notification_desc" => "Te notifica cuando se publica un nuevo comentario en un artículo de autoservicio.", | ||
|
|
||
| /* |
There was a problem hiding this comment.
The newly added string "not_published" on line 170 is in English but should be translated to Spanish. Consider translating "Not Published" to "No Publicado" to match the existing translation pattern where "published" is "Publicado" (line 21).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synced files with /addon-language-english.
This PR was created automatically by #15532948543