feat: gracefully handle expired token exception#69
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Pollcast’s socket ID verification flow to treat expired JWT socket tokens as an authentication failure (401) rather than an unhandled error, and adds functional coverage for the new behaviors.
Changes:
- Add
ExpiredSocketExceptionand throw it when JWT decoding fails specifically due to expiration. - Update
VerifySocketIdmiddleware to return structured JSON 401 responses for invalid/expired socket IDs. - Expand functional tests to cover missing/invalid/expired/malformed JWT socket ID headers and missing
idclaim cases.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/Functional/VerifySocketIdMiddlewareTest.php | Updates expected status codes to 401 and adds new test cases for expired/malformed/missing-claim JWTs. |
| src/Http/Middleware/VerifySocketId.php | Converts socket validation failures into JSON 401 responses; adds special handling for expired tokens. |
| src/Exception/ExpiredSocketException.php | Introduces a dedicated exception type for expired socket JWT tokens. |
| src/Broadcasting/Socket.php | Differentiates expired JWT decode failures from other JWT decode errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bytestream
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.