Skip to content

Fixes iOS resize flicker, jQuery mobile pagechange issue, less than one column bug, and jshint - #22

Open
pandaiolo wants to merge 10 commits into
suprb:masterfrom
pandaiolo:master
Open

Fixes iOS resize flicker, jQuery mobile pagechange issue, less than one column bug, and jshint#22
pandaiolo wants to merge 10 commits into
suprb:masterfrom
pandaiolo:master

Conversation

@pandaiolo

Copy link
Copy Markdown

Here are the two issues fixed in this pull request, along with small fixes by jshint:

  • iOS resize event beeing fired a lot on scroll behaviour
    Grid-A-Licious would flicker / scroll to top every few seconds. I added a check on the width to trigger redraw only if the width actualy changes.
  • jQuery Mobile page transition
    width would be equal to zero upon page change in jQuery mobile, which would need to trigger Grid-A-Licious later (w/ visible flicker). Instead I changed the way width is calculated, by switching the display css value to block while getting the good value.

Notes:

  • Also included @falconwhite pull, with a Math.max instead of the if
  • Applied jshint fixes
  • minified file is up to date

(I did not included the older pull, as it's more than just bugfixing)

@connor

connor commented Sep 28, 2013

Copy link
Copy Markdown

This looks good to me! @suprb what do you think?

@someok

someok commented Sep 29, 2014

Copy link
Copy Markdown

yeah, it work fine, 3kx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants