Fixes iOS resize flicker, jQuery mobile pagechange issue, less than one column bug, and jshint - #22
Open
pandaiolo wants to merge 10 commits into
Open
Fixes iOS resize flicker, jQuery mobile pagechange issue, less than one column bug, and jshint#22pandaiolo wants to merge 10 commits into
pandaiolo wants to merge 10 commits into
Conversation
|
This looks good to me! @suprb what do you think? |
|
yeah, it work fine, 3kx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the two issues fixed in this pull request, along with small fixes by jshint:
Grid-A-Licious would flicker / scroll to top every few seconds. I added a check on the width to trigger redraw only if the width actualy changes.
widthwould be equal to zero upon page change in jQuery mobile, which would need to trigger Grid-A-Licious later (w/ visible flicker). Instead I changed the waywidthis calculated, by switching thedisplaycss value toblockwhile getting the good value.Notes:
Math.maxinstead of theif(I did not included the older pull, as it's more than just bugfixing)