Made Grid-a-licious more responsive - #4
Open
mjcampagna wants to merge 11 commits into
Open
Conversation
|
This is pretty cool. Is this going to be pulled anytime? Otherwise, could you maybe revise it to work with the version 3.0.1? |
globeFrEak
added a commit
to CWCLAN/Grid-A-Licious
that referenced
this pull request
Dec 14, 2014
suprb#4 I made a few changes to the script to make it more responsive by eliminating the JS 'width' and 'gutter' options, and fetching the information dynamically from CSS. Works with media queries too. CHANGES: - removed 'gutter' and 'width' options - script now fetches outer-width and margins from CSS and calculates grid dynamically. - accepts media queries. - example styling: .item { float: left; margin: 0 8px 24px; padding: 8px; width: 250px; } @media only screen and (max-width: 600px) { .item { width: 150px; } } This update to the script also resolves the other issues I've filed, btw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a few changes to the script to make it more responsive by eliminating the JS 'width' and 'gutter' options, and fetching the information dynamically from CSS. Works with media queries too.
CHANGES:
- removed 'gutter' and 'width' options
- script now fetches outer-width and margins from CSS and calculates grid dynamically.
- accepts media queries.
- example styling:
This update to the script also resolves the other issues I've filed, btw.