Repository navigation
SWF(refactor): E2E ページオブジェクトのヘッダー・フッター初期化を基底クラスにまとめる - #810
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
blog | 5b5491f | Commit Preview URL Branch Preview URL |
Nov 20 2026, 03:41 AM |
Contributor
Author
QA結果: 合格ページオブジェクトの共通化の前後で、E2Eの結果は同じでした。マージベース
確認できなかったこと
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2E のページオブジェクト5つが同じ
page・header・footerの初期化を重複して持っていたため、共通の基底クラスSitePageにまとめた。テストの挙動と spec の書き方は変わらない。HomePage、AboutPage、ArticlePage、TagPage、NotFoundPageRssFeedPageはヘッダーとフッターを持たないため、変更していないpage、header、footerなどのプロパティ)は同じで、spec ファイルは変更していないdocs/e2e-testing.mdのディレクトリ構成とページオブジェクトの一覧にsite-page.tsを追記した動作確認
このブランチで次のコマンドを実行した。
pnpm run lint(hint 2件は既存の ESLint 設定にある
includeIgnoreFileの非推奨の警告で、この PR とは関係ない)pnpm run build:e2eのあとpnpm run test:e2e --project=chromiumビジュアルスナップショットのテスト3件を含め、すべて通った。スナップショットは更新していない。
試すコマンド:
pnpm run build:e2e && pnpm run test:e2e --project=chromium未確認: chromium 以外のブラウザのプロジェクトはローカルで実行していない(CI で確認する)。
Implemented in session Share Header/Footer setup in E2E page objects
Review with Devin · Open in Devin Desktop