Repository navigation
SWF(refactor): define the Playwright E2E port in one place - #811
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
blog | 933ef9d | Commit Preview URL Branch Preview URL |
Nov 20 2026, 03:42 AM |
Contributor
Author
QA結果: 合格(933ef9d)E2Eと見た目のテストは、どちらも変わらずポート4322で動きました。
画面の変更がない設定だけのPRなので、録画とスクリーンショットは付けていません。失敗はありませんでした。 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The E2E port
4322is now defined only inplaywright.config.ts. Before this change,playwright.visual.config.tshardcoded it a second time. Behavior is unchanged.webServer.urlnow comes from the base config through the existing...config.webServerspread. After this change, the runtime config has exactly one4322literal. The other matches are explanatory examples indocs/and the historical design and plan docs, which are left as they are.Evidence (run on this branch)
Test discovery is the same before and after. Running
diff -uon the--listoutput before and after the change gave no differences for either config:Default config, real run on port 4322:
Visual config, real run on port 4322 (command built from
e2ePort):pnpm run lint: 0 errors and 0 warnings. There are 2 hints, both about the existingincludeIgnoreFiledeprecation.Try it:
pnpm exec playwright test --config=playwright.visual.config.ts --listNot run locally: the full visual suite. Only one visual test was run. CI covers the rest.
Implemented in session Define E2E port in one place
Review with Devin · Open in Devin Desktop