Repository navigation
SWF(refactor): ヘッダーとフッターの SNS リンク定義を共通化する - #812
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
blog | 860d48b | Commit Preview URL Branch Preview URL |
Nov 20 2026, 03:44 AM |
Contributor
Author
|
PR
録画(チャプター付きビューア) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ヘッダーとフッターで3か所ずつ重複していた SNS リンク(URL・aria-label・アイコン名)を
src/lib/social-links.tsのsocialLinksにまとめました。出力される HTML は変わりません。変更内容
HeaderIcons.astroとFooter.astroはsocialLinks.map(...)で描画します。HeaderIcon(rel="noopener noreferrer"付き)、フッターはtext-gray-600のリンク(relなし)です。動作の証拠
ネットワークをスタブする
build:e2eで、main とこのブランチのdist/を比べました。48 個の HTML を含む全ファイルが一致します。このブランチで出力されたヘッダーとフッターの Twitter リンクです(
dist/index.html)。pnpm run lint: 0 errors, 0 warningspnpm run test:e2e --project=chromium: 70 passed, 2 skipped(ヘッダーのビジュアルリグレッションを含む)通常の
build:ciでも比べましたが、外部サイトから取得するリンクカード画像だけがビルドごとに変わったため、証拠には使っていません。試し方
未確認
実際の画面の確認は QA Engineer に依頼します。
Implemented in session Share social link data across header and footer
Review with Devin · Open in Devin Desktop