Repository navigation
Conversation
Co-Authored-By: Daiki Sato <d@sur33.com>
Co-Authored-By: Daiki Sato <d@sur33.com>
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
blog | bc3644b | Commit Preview URL Branch Preview URL |
Nov 20 2026, 03:50 AM |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ハンバーガーメニューの状態を変える処理を
openMenu()/closeMenu()にまとめ、イベント処理からはこの2つを呼ぶだけにしました。動作は変えていません。data-active、aria-expanded、document.body.style.overflow、keydown リスナーの登録と解除、初回のstartクラスの削除)はopenMenu()/closeMenu()だけで行います。matchMedia('(min-width: 640px)')のハンドラは、開くか閉じるかを決めて上の2つを呼びます。if (hamburger) { ... }で包んでいた処理をif (!hamburger) return;の早期リターンにし、ネストを1段減らしました。./hamburgerMenu.jsからの import 例を@scripts/menuにし、「をを」の誤字と、現在の動作と合わない説明を修正しています。実行結果
メニューに関わる Chromium の E2E を、main とこのブランチの両方で
pnpm run build:e2eの後に実行し、同じ結果になりました(skip の1件は mobile プロジェクト専用のテストです)。pnpm run lintは 0 errors、0 warnings です(hint 2件は既存のeslint.config.jsのincludeIgnoreFileの非推奨警告)。試すコマンド:
pnpm run build:e2e && pnpm exec playwright test tests/e2e/specs/navigation.spec.ts --project=chromium未確認
docs/layouts.mdの古い記述はメニューと関係しないため、この PR では直していません。Implemented in session Separate menu state from event handling
Review with Devin · Open in Devin Desktop