Skip to content

fix(auth): preserve fail-closed behavior without server key - #38

Merged
surendra2304 merged 1 commit into
mainfrom
fix/auth-configured-key-source-20261024
Oct 23, 2026
Merged

surendra2304 merged 1 commit into
mainfrom
fix/auth-configured-key-source-20261024

Conversation

@surendra2304

Copy link
Copy Markdown
Owner

Summary

  • Avoid treating the INFERENCE_API_KEY environment variable as a second fallback after the canonical settings key.
  • Preserve 503 when the service has no configured key, 401 for missing client credentials, and 403 for invalid credentials.

Verification

  • GitHub Actions will execute the existing authentication and full Inference test suite.
  • No auth gate has been relaxed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T21:21:02.778749Z 363ebfa PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@surendra2304
surendra2304 merged commit 2c73a9a into main Oct 23, 2026
1 check passed
@surendra2304
surendra2304 deleted the fix/auth-configured-key-source-20261024 branch October 25, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant