Fix CoreMark benchmark comparison validity - #1
Draft
arthurianresolve wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainimplementations with the same CoreMark harness and workload.Why
This is a focused follow-up to nasa#124. Its baseline currently predates
COREMARK_FIXED_CLOCK, so the PR cannot exercise its own two-sided Callgrind comparison. It also treats the widest range from three timed samples as a regression threshold, although that range is not a confidence bound.Saving the PR harness before checking out
mainholds the measurement apparatus constant while varying the implementation under test. Both sides must then produce the known10.000fixed-clock score before instruction counts are accepted.Validation
cargo fmt --all -- --checkcargo check -p spacewasm_std --benchescargo clippy -p spacewasm_std --benches -- -Dwarningsgit diff --checkmainrebuilt with the saved harness both producedCoreMark Score: 10.000with fourclock_mscallsScope
Two workflow files only; no Rust production code changes.
AI usage disclosure
OpenAI Codex was used to analyze PR nasa#124, implement the changes in
.github/workflows/ci.ymland.github/workflows/comment.yml, and run the validation listed above. The resulting diff is submitted for author and maintainer review.