Skip to content

Sharing#10

Open
cherylac wants to merge 2 commits into
masterfrom
sharing
Open

Sharing#10
cherylac wants to merge 2 commits into
masterfrom
sharing

Conversation

@cherylac

@cherylac cherylac commented Feb 11, 2019

Copy link
Copy Markdown
Collaborator

closes #8
Added icons to link to social.

Comment thread index.html
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="apple-touch-icon" href="apple-touch-icon.png">

<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css"><!--for sharing icons-->

@DerekJB1987 DerekJB1987 Feb 25, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to successfully view all the social media icons you added in the browser and endorse merging with the master branch.

Comment thread index.html
ga('create','UA-XXXXX-X','auto');ga('send','pageview');
</script>

<!-- Add font awesome icons -->

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe if we wrap this in a div with an id or container, and style it with margin 0 auto we can get the icons more center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sharing

3 participants