implement packageOverrides argument#24
Open
charlieshanley wants to merge 1 commit into
Open
Conversation
Owner
|
Hi, I'm afraid due to my earlier changes this pull request is conflicting. I think the overriding feature can be quite useful. Would it be possible for you to rebase your changes? Furthermore, can you also write a small example that can be added to the README.md? Otherwise, it's a hidden feature and there's a chance this will bit rot because it can't be properly tested and maintained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so the generated nix expressions accept the argument
packageOverrides, which allows users to override the derivations of dependencies.This is desirable in the case that a dependency cannot be built with nix as-is -- my motivating case was a package that wanted to make network requests in
post-install-cmd.packageOverridesshould be an attrset whose values are a function from the old derivation to a new one.Here is an example: