Repository navigation
fix: print the type parameters of object-literal methods - #184
Merged
dummdidumm merged 2 commits intoSep 3, 2026
Merged
Conversation
`{ m<T>(x: T) {} }` was printed as `{ m(x: T) {} }`: the `Property`
visitor never visited `value.typeParameters`.
|
Install the latest version of pnpm add https://pkg.svelte.dev/esrap/c/d7d52825751c814bdd769a390b0dc33af69ad546Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: d7d5282 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
approved these changes
Sep 3, 2026
dummdidumm
reviewed
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #183 at the maintainers' request.
Object-literal methods lost their type parameters when printed:
{ m<T>(x: T) {} }came out as{ m(x: T) {} }. ThePropertyvisitor's method branch never visitedvalue.typeParameters.The test parses with oxc because acorn-typescript cannot parse type parameters on object-literal methods.
🤖 Generated with Claude Code