Repository navigation
fix: print a semicolon after body-less class methods - #186
Merged
Merged
Conversation
Abstract methods, abstract accessors and overload signatures in classes were printed with a trailing space and no semicolon (`abstract get a() `), which is not valid TypeScript. Write `;` when the method has no body instead of the space that precedes one. The existing abstract-class snapshot had recorded the broken output.
|
Install the latest version of pnpm add https://pkg.svelte.dev/esrap/c/3e538d17eef4237e002d5f497106fe4e5f70fdf4Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 3e538d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
reviewed
Sep 3, 2026
dummdidumm
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #183 at the maintainers' request.
Abstract methods, abstract accessors and class overload signatures were printed with a trailing space and no semicolon, which is not valid TypeScript:
The method visitor wrote the space before the body unconditionally. It now writes the space only when there is a body and a semicolon otherwise. The existing
ts-abstract-classsnapshot had recorded the broken output; it is regenerated and extended with an abstract method that has parameters and a return type, and an overload pair.🤖 Generated with Claude Code