Repository navigation
fix: keep the import attributes of an import type - #250
Open
GBra-4-669 wants to merge 1 commit into
Open
GBra-4-669 wants to merge 1 commit into
GBra-4-669 wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/esrap/c/265c75452192b644474127a3f9d04abe97a7b02eOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #231
TSImportTypenever visitsoptions, so import attributes are dropped:That changes the meaning, not just the formatting, since
resolution-modeaffects which declarations TypeScript resolves.The fix prints
optionsinside the parens, same as theImportExpressionvisitor already does. I also checked it against typescript-estree (the reporter's parser), not just oxc. The repro goes from 1 identical / 4 wrong to 5 identical / 0 wrong.The tests use
oxc-parserbecauseacorn-typescriptcan't parse attributes on an import type.