Repository navigation
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/esrap/c/19c7929db3eaf75bd18ccc83f39538adc360cc7dOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 19c7929 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
AssignmentPatternprinted itsleftas-is, so a TypeScript cast used as the target of a destructuring default lost the parentheses it needs:#218 already wraps casts on the left of an
AssignmentExpression. This moves that check into a smallis_casthelper and uses it inAssignmentPatterntoo, soas,satisfiesand<T>xtargets keep their parentheses in object and array patterns. Defaults without a cast ({ a = 1 },[b = 2],c = 3) and casts on the right-hand side ({ a = 1 as any }) print as before.Tests
test/samples/ts-as-precedencecovering an object pattern, an array pattern, a member target,satisfiesand an angle-bracket assertion, and updated the snapshot and map.ts.createSourceFileandoxc-parser: without the change, the five cast cases from the issue fail to parse in TypeScript; with it they all parse.pnpm test(516 passed),pnpm checkandpnpm lintpass.