feat: add a configuration option for other file extensions#621
feat: add a configuration option for other file extensions#621tshort wants to merge 3 commits intosvsool:masterfrom
Conversation
|
Thanks for contributing @tshort!
Let me know if this approach works for you: https://github.com/svsool/memo/blob/master/CONTRIBUTING.md#run-tests |
|
I've tried a few things, but I can't get Also, it doesn't look like the CI is running for this PR (Secret VSCE_PAT is required, but not provided while calling). Is there anything I need to do to enable that? |
Checked this locally as well and indeed there is an issue with tests in latest vscode version that will need some investigation. Update: After some investigation I found that commenting this code makes tests run (needs a proper fix though), seems like require logic in latest vscode changed. |
|
Hi @tshort, tests should be fixed now, please rebase, update NodeJS to v16.14.2, reinstall packages and let me know if works. I'd suggest also to add tests for |
This option allows the user to specify a list of "other" file extensions. These are in addition to Markdown and image files. This is an array. For the special case of
["*"], all files are supported, regardless of extension.This partially fixes requests in #592 and #593.
I took a shot at a test, but I can't figure out how to run tests locally, so I don't know if it works. This option also needs to be documented.