Fix hidden overlay chrome intercepting new selection drags#219
Open
chablino wants to merge 2 commits into
Open
Fix hidden overlay chrome intercepting new selection drags#219chablino wants to merge 2 commits into
chablino wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates OverlayView hit-testing so clicks on inactive/hidden chrome (toolbars/strips/options row) are ignored and routed back to the overlay instead of the chrome subviews.
Changes:
- Overrides
hitTest(_:)to post-process the result and returnselffor inactive chrome hits. - Adds helper methods to detect whether the hit view is within chrome and whether any ancestors are hidden.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an intermittent issue where starting a new screenshot selection could fail when the drag began over the previous position of hidden overlay chrome, such as the tool options row.
The overlay reuses toolbar/options views between capture sessions. In some cases,
super.hitTest(_:)could still resolve a mouse-down to a hidden or inactive chrome subview, preventingOverlayView.mouseDown(with:)from starting the selection.This change keeps visible toolbar/options behavior unchanged, but ignores hidden or inactive overlay chrome hits and routes those mouse events back to
OverlayView.Test Plan
xcodebuild -project macshot.xcodeproj -scheme macshot -configuration Debug -derivedDataPath / private/tmp/macshot-derived-data CODE_SIGNING_ALLOWED=NO buildDemo
Before
before.mp4
After
after.mp4