Templates Design pass - #66
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gordon-stripe
left a comment
gordon-stripe
left a comment
There was a problem hiding this comment.
Some small comments
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <link rel="canonical" :href="base.siteOrigin + page.url"/> | ||
| <link rel="canonical" :href="this.canonicalUrl || (base.siteOrigin + page.url)"/> |
There was a problem hiding this comment.
What are the changes to this file for?
There was a problem hiding this comment.
This is to support the new template pages. They need an explicit canonicalUrl / ogUrl override so each generated page gets the correct metadata; all existing pages still use the old base.siteOrigin + page.url fallback.
See src/templates/family.11ty.js and src/templates/variant.11ty.js where we set these values for each of the templates.
| } | ||
| } | ||
|
|
||
| const parseResponsiveAttr = (container, baseName) => { |
There was a problem hiding this comment.
Why do we need this vs just building responsive CSS?
There was a problem hiding this comment.
Maybe a bigger question than this PR
There was a problem hiding this comment.
@mikestilling-stripe can you help with this question?
There was a problem hiding this comment.
I added this because I needed to reposition the 3d object within the canvas element. Maybe this is achievable with CSS?
There was a problem hiding this comment.
While I'm very familiar with 11ty, Tailwind, and Webc—I'm not too familiar with WebGl, this part is fully vibe coded.
3 participants
A design pass on PR 64.
Currently kicking around ideas—refactoring some things to make it easier to design. Happy to retrofit into the current JS structure once I get something that looks decent. (mostly, moved away from JS and made use of 11ty's built-in templating and data cause I'm not very handy with JS)