Skip to content

fix: valid always throws an error if called with two arguments #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swantzter merged 1 commit into from
May 29, 2026
Merged

fix: valid always throws an error if called with two arguments #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export default class Kontonummer {
// eslint-disable-next-line @typescript-eslint/unified-signatures
public static valid (sortingCode: string | number, accountNumber: string | number): boolean
public static valid (sortingCodeWithOrWithoutAccountNumber: string | number, accountNumber?: string | number) {
if (accountNumber && (typeof accountNumber !== 'string' || typeof accountNumber !== 'number')) throw new KontonummerError('Kontonummer.valid() does not accept an options argument')
if (accountNumber && !(typeof accountNumber === 'string' || typeof accountNumber === 'number')) throw new KontonummerError('Kontonummer.valid() does not accept an options argument')
try {
if (accountNumber) new Kontonummer(sortingCodeWithOrWithoutAccountNumber, accountNumber) // eslint-disable-line no-new
else new Kontonummer(sortingCodeWithOrWithoutAccountNumber) // eslint-disable-line no-new
Expand Down
Loading