-
Notifications
You must be signed in to change notification settings - Fork 678
fix: resolve dunkscore parse issue #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@rsforbes can you review this? |
brandonhawi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but overall looks good 👍🏼
|
@brandonhawi |
|
@brandonhawi I reflected the review |
brandonhawi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contributions. Left one small documentation comment but otherwise awesome work!
Co-authored-by: Brandon Hawi <brandonhawi1@gmail.com>
|
@brandonhawi thank you. I commited your comment |
|
Any update here? |
brandonhawi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, another small nitpick
|
@brandonhawi thx. I made a commit |
|
My apologies for my lack of response here. Just some questions so I can get the context on here:
And is the following code below accurate when trying test it out? result = dunkscoreleaders.DunkScoreLeaders(
season="2025-26",
)
print(result.get_dict()) |
|
@swar thanks for comment.
Before the change, a custom parser was not implemented, and it referenced a key named
From Dunks -> dunks. rawResponse on the issue. As I am not a native English speaker, the precise nuances may not be entirely accurate. |
I've checked as below. team_id and player_id looks *required params. from nba_api.stats.endpoints.dunkscoreleaders import DunkScoreLeaders
result = DunkScoreLeaders(
season="2025-26",
team_id_nullable="1610612737",
player_id_nullable="1630168",
)
print(result.get_dict()) |
I'm not sure that best response structure, but this resolve issue.
resolve issue as below