Skip to content

Conversation

@poteto0
Copy link

@poteto0 poteto0 commented Nov 17, 2025

I'm not sure that best response structure, but this resolve issue.

resolve issue as below

@poteto0
Copy link
Author

poteto0 commented Nov 23, 2025

@rsforbes can you review this?

Copy link
Contributor

@brandonhawi brandonhawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but overall looks good 👍🏼

@poteto0
Copy link
Author

poteto0 commented Dec 8, 2025

@brandonhawi
Thanks. I'll check in a few days

@poteto0
Copy link
Author

poteto0 commented Dec 11, 2025

@brandonhawi I reflected the review

Copy link
Contributor

@brandonhawi brandonhawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contributions. Left one small documentation comment but otherwise awesome work!

Co-authored-by: Brandon Hawi <brandonhawi1@gmail.com>
@poteto0
Copy link
Author

poteto0 commented Dec 12, 2025

@brandonhawi thank you. I commited your comment

@poteto0
Copy link
Author

poteto0 commented Dec 26, 2025

Any update here?

Copy link
Contributor

@brandonhawi brandonhawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, another small nitpick

@poteto0
Copy link
Author

poteto0 commented Jan 5, 2026

@brandonhawi thx. I made a commit

@swar
Copy link
Owner

swar commented Jan 9, 2026

My apologies for my lack of response here.

Just some questions so I can get the context on here:

  • It seems like this issue popped up because of a potentially change in structure of how this data was being returned. Is that correct?
  • Is the change from dunks -> Dunks because that's what's being done on the endpoint?

And is the following code below accurate when trying test it out?

result = dunkscoreleaders.DunkScoreLeaders(
        season="2025-26",
)
print(result.get_dict())

@poteto0
Copy link
Author

poteto0 commented Jan 10, 2026

@swar thanks for comment.

It seems like this issue popped up because of a potentially change in structure of how this data was being returned. Is that correct?

Before the change, a custom parser was not implemented, and it referenced a key named resultSet. Upon examining the rawResponse, a value was found under the key dunks.
Therefore, a custom parser was implemented to reference dunks instead.

Is the change from dunks -> Dunks because that's what's being done on the endpoint?

From Dunks -> dunks.
I don't know the original circumstances, but since the response was “dunks,” I've adopted it as is.

rawResponse on the issue.

#597

As I am not a native English speaker, the precise nuances may not be entirely accurate.

@poteto0
Copy link
Author

poteto0 commented Jan 10, 2026

@swar

And is the following code below accurate when trying test it out?

I've checked as below.

team_id and player_id looks *required params.

from nba_api.stats.endpoints.dunkscoreleaders import DunkScoreLeaders

result = DunkScoreLeaders(
    season="2025-26",
    team_id_nullable="1610612737",
    player_id_nullable="1630168",
)
print(result.get_dict())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants