Skip to content

Conversation

@eac521
Copy link

@eac521 eac521 commented Jan 14, 2026

Issue: JSONDecodeError / timeout when calling PlayerGameLogs
Missing: NBA.com now requires ISTRound, PaceAdjust, PlusMinus, Rank parameters
Action: These parameters are added into the playergamelogs params dictionary, these parameters were found by going to the nba.com/stats site and finding the api and comparing the url to the previous
testing: api has worked 1/11/2026 and 1/12/2026 data

…: Rank, PaceAdjust, ISTRound and PlusMinus
@swar
Copy link
Owner

swar commented Jan 21, 2026

@eac521

Your MR will need some cleanup. The .DS_Store files needs to be removed. In addition, your changes aren't following the patterns in the file. If these are new parameters, then we need to give folks the ability to enter custom values here. So we'll need to add these as parameters in the __init__.

… file with proper Nullable classes. Removed out superflous DS_Store files.
@eac521
Copy link
Author

eac521 commented Jan 22, 2026

Thanks for your patience with me and creating this repo! it is really a fantastic setup and has helped me a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants