Repository navigation
ci: add gradle caching and release workflow - #4
Merged
Merged
Conversation
adimail
requested changes
Apr 4, 2026
adimail
left a comment
Collaborator
There was a problem hiding this comment.
PR Review: ci/workflows → main
build.yml
🔴 Wrong trigger — builds on every push, not just PRs
The workflow fires on both push and pull_request, meaning it runs on every
push to every branch. Since the intent is to catch issues on PRs, restrict it
to pull_request only.
🔴 No explicit test step
./gradlew build does run tests in most Gradle setups, but being explicit is
safer and more readable. Rename the build step to test and run ./gradlew test instead.
🟡 Artifact upload doesn't belong here
Uploading artifacts on every PR run is noisy and wasteful. The
capture build artifacts step should live only in release.yml.
release.yml
🟡 Use assemble instead of build
Tests already passed on the PR — re-running them at release time is redundant
and slow. Use assemble to just produce the JAR without re-running tests.
✅ What's Good
- Tag pattern
v*correctly scopes the release trigger permissions: contents: writeis correctly and minimally scopedgenerate_release_notes: trueis a nice touch- All actions pinned to major versions (
@v4,@v2)
Summary
| # | File | Issue | Severity |
|---|---|---|---|
| 1 | build.yml |
Triggers on push — should be pull_request only |
🔴 |
| 2 | build.yml |
No explicit test step | 🔴 |
| 3 | build.yml |
Artifact upload on every PR is unnecessary | 🟡 |
| 4 | release.yml |
Use assemble not build |
🟡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.