Repository navigation
feat(tui): Warp visual pass — input block, pill chips, accent spinner - #7
Conversation
Second Warp-fidelity pass after the quiet-landing rework: - Prompt: drop the per-turn chip row, folder icon, and chevron. The input line now opens with Warp's solid accent block (▌▌) followed by plain directory text and a dim branch — matching Warp's block prompt. - Splash chips: rainbow key/label pairs become Warp pills — key on a filled accent (cyan/violet/magenta/lime rotation), role in muted text beside it. - Spinner: terminal green replaced with the Warp accent blue tick and near-white label. - Tool output: payload lines indent under their TOOL lane header so output visually groups with its tool call. Co-Authored-By: AimeeCodes <noreply@aimeecodes.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThe PR applies a Warp-inspired visual refresh to interactive terminal surfaces.
Confidence Score: 4/5The PR appears safe to merge, with only a non-blocking request to rewrite the modified prompt tests around complete expected values. The visual and output-formatting changes have no established blocking failure, but the changed prompt tests verify isolated substrings instead of the complete layout required by the repository’s testing contract. Files Needing Attention: crates/aimee_main/src/prompt.rs
|
| Filename | Overview |
|---|---|
| crates/aimee_main/src/prompt.rs | Reworks the left prompt into a single-line block layout; the updated tests do not follow the repository’s required whole-value test structure. |
| crates/aimee_main/src/banner.rs | Converts splash chips to filled accent pills with muted role labels. |
| crates/aimee_main/src/ui.rs | Adds four-space indentation to nonblank tool-output lines. |
| crates/aimee_main/src/theme.rs | Adds dedicated styles for the prompt block, directory, and branch. |
| crates/aimee_spinner/src/lib.rs | Recolors spinner ticks and labels to the Warp-inspired palette. |
Reviews (1): Last reviewed commit: "feat(tui): Warp visual pass — input bloc..." | Re-trigger Greptile
| // Warp input block leads the line. | ||
| assert!(actual.contains(WARP_INPUT_BLOCK)); | ||
| // Test cwd "." has no file_name → placeholder marker renders. | ||
| assert!(actual.contains(markers::EMPTY)); | ||
| // No chip row above the prompt anymore (Warp-quiet). | ||
| assert!(!actual.contains(":muse")); | ||
| } | ||
|
|
There was a problem hiding this comment.
Prompt tests check partial output
The modified tests assert selected substrings instead of defining the required fixture, actual, and complete expected prompt values. This leaves spacing, line structure, and ordering unverified; please update both prompt tests to compare the full rendered output.
Rule Used: # AGENTS.md
House rules for coding agents in the ... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
Second Warp-fidelity pass after #6's quiet-landing rework. This pass targets the interactive surfaces — what you look at every turn, not just startup.
/opens the palette).Test Plan
cargo test -p aimee_main -p aimee_spinner: 379 passed, 0 failed (prompt tests updated to assert block + no-chip-row)cargo clippy -p aimee_main -p aidee_spinner --all-targets -- -D warnings: clean!echo flow intactCo-Authored-By: AimeeCodes noreply@aimeecodes.dev