Repository navigation
Remove backup files from production repository - #21
Conversation
Co-authored-by: SomeRandmGuyy <127457986+SomeRandmGuyy@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR performs cleanup by removing obsolete backup, duplicate, and "fixed" versions of configuration and code files. The changes streamline the repository by eliminating redundant versions of setup scripts, pytest configuration files, and pyproject.toml files, while adding appropriate .gitignore entries to prevent such files from being committed in the future.
Key Changes
- Removed multiple versions of setup scripts (setup.py, setup_fixed.py, setup_original.py)
- Removed duplicate pyproject.toml files (*_fixed, *_original, *_new, *_simple versions)
- Removed duplicate pytest configuration files (*.backup, *_simple versions)
- Removed duplicate/backup CLI and test runner scripts
- Removed obsolete enhanced_continuum_state_new.py
- Updated .gitignore to prevent future backup/duplicate files from being committed
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_runner_fixed.py | Removed duplicate test runner implementation |
| src/tests/unit/test_data_generator_fixed.py | Removed duplicate test file |
| src/fsl_continuum/cli_original.py | Removed duplicate CLI implementation |
| src/config/enhanced_continuum_state_new.py | Removed obsolete state management module |
| setup_original.py, setup_fixed.py, setup.py | Removed multiple versions of setup script |
| pyproject_*.toml files | Removed duplicate pyproject.toml variants |
| pytest_simple.ini, pytest.ini.backup* | Removed duplicate pytest configuration files |
| cli_fixed.py | Removed duplicate CLI script at root level |
| .gitignore | Added patterns to exclude backup and duplicate files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| """ | ||
| FSL Continuum Setup Script - Fixed Version | ||
|
|
||
| Legacy setup script for compatibility with older pip versions and build systems. | ||
| New installations should use pyproject.toml (PEP 517/518). |
There was a problem hiding this comment.
The commit deletes setup.py, but validate_production_readiness._test_package_files() still hard‑requires that file (required_files = ['pyproject.toml', 'setup.py', 'MANIFEST.in']). After this change the deployment validation will always fail because the check can never pass. Either reinstate setup.py or update the validation logic to accept the pyproject‑only layout.
Useful? React with 👍 / 👎.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Comments (3)
-
MANIFEST.in, line 14 (link)syntax:
setup.pywas deleted in this PR but is still referenced here, causing package distribution failures -
validate_production_readiness.py, line 670 (link)logic:
setup.pywas deleted in this PR, causing this validation to fail -
pyproject.toml, line 301 (link)style:
setup.pywas deleted but still referenced in coverage omit list
17 files reviewed, 3 comments
@copilot please fix these issues found in review |
….py, and pyproject.toml Co-authored-by: SomeRandmGuyy <127457986+SomeRandmGuyy@users.noreply.github.com>
22b28c0
into
feature/production-restructuring
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Greptile Overview
Updated On: 2025-11-04 05:34:04 UTC
Greptile Summary
This PR removes 16 backup and temporary files (
.backup,_fixed.py,_original.py, etc.) that were accidentally committed during a previous spec upgrade. It also adds comprehensive.gitignorepatterns to prevent future backup file commits.Major changes:
setup.py,cli.py,test_data_generator.py, and configuration files.gitignorepatterns covering various backup file naming conventionsCritical issues found:
MANIFEST.in:14still references the deletedsetup.py, which will cause package distribution to failvalidate_production_readiness.py:670expectssetup.pyto exist, causing production readiness validation to failpyproject.toml:301has obsolete reference to deletedsetup.pyin coverage omit list (non-critical)Confidence Score: 1/5
setup.pyremain: MANIFEST.in:14 will cause package build failures, and validate_production_readiness.py:670 will cause production checks to fail. These must be fixed before merging.setup.pyImportant Files Changed
File Analysis
setup.pyfile - will cause package distribution failuressetup.pyto exist - will cause production readiness checks to failsetup.pyin coverage omit list (non-critical)Sequence Diagram
sequenceDiagram participant Dev as Developer participant Git as Git Repository participant CI as CI/CD Pipeline participant Pkg as Package Build Dev->>Git: Commit PR #21 (Remove backup files) Note over Git: Delete 16 backup files<br/>(setup.py, *_fixed.py, etc.) Note over Git: Update .gitignore<br/>(Add backup patterns) Git->>CI: Trigger validation checks CI->>Pkg: Run validate_production_readiness.py Pkg--xCI: ❌ FAIL: setup.py not found Note over Pkg: Line 670 expects setup.py CI->>Pkg: Attempt package build Pkg--xCI: ❌ FAIL: MANIFEST.in error Note over Pkg: Line 14 references deleted setup.py CI--xDev: ❌ Build/Validation Failed Note over Dev: Must fix references before merge