Skip to content

Add initial frequency function#12

Merged
Advayp merged 6 commits into
swecc-uw:mainfrom
kvn147:main
May 17, 2025
Merged

Add initial frequency function#12
Advayp merged 6 commits into
swecc-uw:mainfrom
kvn147:main

Conversation

@kvn147

@kvn147 kvn147 commented May 13, 2025

Copy link
Copy Markdown
Contributor

Hello,

I have added a frequency.py file under the command directory that outputs a specific course codes offerings and frequencies per quarter within the last set amount of years. I then added frequency to cli.py as a command option with args course code and years to check (default 5 years). I checked code quality with the linter, formatting, type checking, and testing.

Comment thread swecc_course_scraper/cli.py Outdated
Comment thread swecc_course_scraper/cli.py Outdated
Comment thread swecc_course_scraper/commands/frequency.py
kvn147 added 2 commits May 14, 2025 19:00
When unable to fetch the schedule for a specific quarter, it logs an exception and skips that quarter.
@Navneethd8

Copy link
Copy Markdown

Run ruff check swecc_course_scraper and black --check swecc_course_scraper in your terminal so that the code follows the formatting that we use.

Then commit those changes as well and one of us will review it again.

@kvn147 kvn147 requested a review from Advayp May 17, 2025 07:49
Comment thread swecc_course_scraper/commands/frequency.py Outdated
Comment thread swecc_course_scraper/cli.py Outdated

@Advayp Advayp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Advayp Advayp merged commit 6de15da into swecc-uw:main May 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants