Changes to colors in the officier side bar#124
Merged
Conversation
Author
|
IMO I think the old "Officer 20XX" is better but I think that's more of a comment of the color scheme being used in the website than misuse of color roles. |
Advayp
approved these changes
Jan 5, 2026
Advayp
left a comment
Advayp
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: Peter Bun
What changes were made?
Replaced broken variable with a header color. I don't know what the side bar header color used to be, but I am assuming the regular header color is appropriate (well the header color is never used in the website it seems, so I just opted in to the title color). Without it, the sidebar color will always be black, which leading to bad contrast in dark mode. I also changed the main "Officer 20XX" to use title color to more consistent to the other pages.
(If applicable) Screenshots of your changes. Providing an “old vs. new” comparison would be great!
New (left) vs. old (right)
