fix: build x264 from source in rpm-builder to resolve x264-sys bindgen failure on Fedora - #1
Draft
swedishborgie with Copilot wants to merge 2 commits into
Draft
fix: build x264 from source in rpm-builder to resolve x264-sys bindgen failure on Fedora#1swedishborgie with Copilot wants to merge 2 commits into
swedishborgie with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Fedora Package
fix: build x264 from source in rpm-builder to resolve x264-sys bindgen failure on Fedora
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPMFusion's
x264-develpackage produces headers wherebindgengeneratesx264_param_tas an opaque 1-byte placeholder instead of the full struct, causing a compile-time size assertion overflow (1_usize - 1024_usize) inx264-sys 0.2.xduring the Fedora RPM build.Changes
docker/Dockerfile.packages(rpm-builderstage)x264-develfrom thednf installlist--enable-shared --disable-cli --prefix=/usr --libdir=/usr/lib64), which exposes a fully-definedx264_param_tthat satisfies thex264-syssize assertionsThe VideoLAN source with default configure flags produces headers where
x264_param_tis fully defined, sobindgengenerates a complete Rust struct and thesize_ofassertion resolves correctly.