i18n(zh): complete zh.json against en.json schema#65
Open
Yananix wants to merge 2 commits into
Open
Conversation
- Align zh.json with all 132 keys from en.json (was 86, missing 60).
- Drop 14 stale keys that no longer exist in en.json (sender.settings.*,
sender.monitor_label.*, sender.status.*_chip, sender.group.source).
- Match key order with en.json so diffs are easier to review.
- Use %{name} placeholder syntax exactly as documented in
docs/Translations.md (no token names translated/removed).
- Keep technical strings (n/a, SCDisplay %{id}, CGDisplayStream %{id},
display_state.summary) unchanged, matching it.json/de.json style.
Verified: 132/132 keys, 0 placeholder mismatches, JSON valid.
Receiver builds and loads zh.json under TB_LANG=zh without fallback.
- sender.section.mode: 'v1 模式' -> '模式 v1'
('v1' is a version number, not a mode name)
- sender.status.starting_capture: add missing '捕获' that was in the
English source ('Starting %{source} capture (%{resolution})...')
- sender.status_chip.live: '进行中' -> '实时'
Live/Connected/Idle reads more naturally as 实时/已连接/空闲
Owner
|
Thanks a lot for this, and for taking the time to align the Chinese translation with the shared JSON localization system. This is exactly the kind of follow-up we were hoping for after the localization refactor. The work is appreciated, and yes: the Chinese translation improvements from this PR are planned to be included in the next release. Really appreciate the help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Built on top of
feature/languages— using the existing JSON layout and%{name}placeholders.This is the follow-up you suggested: just the Chinese translations, adapted to your shared JSON system. Nothing else is touched.