[fixed] fix pitfall when using == and != with MangedWeakReference #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallchildren
force-pushed
the
managedweakref_compare_issues
branch
from
896d66a to
32449f4
Compare
The following steps should illustrate the problem: 1. Object A is freshly constructed and gets an _objectID of 0. 2. ManagedWeakReference of A is created -> savedObjectID will be also 0 3. ObjectManager::persist is called and A gets a validi _objectID 4. ManagedWeakReference of A will still have the savedObjectID of 0 and will result in wrong behaviour of == and != To circumvent these this commit changes the case when one of the compared ManagedWeakReference instances has a savedObjectID of 0 and checks the actual reference object for the real _objectID.
fallchildren
force-pushed
the
managedweakref_compare_issues
branch
from
32449f4 to
1031682
Compare
Author
|
Reworked the logic to make it more clear and all cases are handled and no unnecessary call to getReferenceUnsafeNoReload is done . |
swgemu2deploy
pushed a commit
that referenced
this pull request
Apr 14, 2024
…ated sigpause' (#2) from Hakry/engine3:master into master Reviewed-on: https://git.swgemu.com/swgemu/engine3/pulls/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following steps should illustrate the problem:
and will result in wrong behaviour of == and !=
To circumvent these this commit changes the case when one of the
compared ManagedWeakReference instances has a savedObjectID of 0 and
checks the actual reference object for the real _objectID.
The issue was found when investigating https://www.swgemu.com/bugs/view.php?id=8229
A reordering fix for the Mantis bug is also on the swgemu gerrit instance see https://review.swgemu.com/c/Core3/+/8940