don't require Foundation to build FlyingSocks#188
Merged
swhitty merged 1 commit intoswhitty:mainfrom Feb 27, 2026
Merged
Conversation
Contributor
Author
|
Leaving as a draft as tests aren't passing. |
For embedded Linux systems, it's ideal to build FlyingSocks without the Foundation dependency (i.e. just with FoundationEssentials, as it doesn't pull in ICU). This requires conditional imports and moving some files around.
ae31e62 to
7d597c9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 92.80% 92.80%
=======================================
Files 68 68
Lines 3448 3448
=======================================
Hits 3200 3200
Misses 248 248 ☔ View full report in Codecov by Sentry. |
swhitty
approved these changes
Feb 27, 2026
Owner
swhitty
left a comment
There was a problem hiding this comment.
great this has been on my list for while, thank you Luke 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For embedded Linux systems, it's ideal to build FlyingSocks without the Foundation dependency (i.e. just with FoundationEssentials, as it doesn't pull in ICU). This requires conditional imports and moving some files around.