Fix module-level SIL/IR output path generation in WMO mode#2076
Open
rjmansfield wants to merge 1 commit intoswiftlang:mainfrom
Open
Fix module-level SIL/IR output path generation in WMO mode#2076rjmansfield wants to merge 1 commit intoswiftlang:mainfrom
rjmansfield wants to merge 1 commit intoswiftlang:mainfrom
Conversation
This generates module level paths when using the SIL/IR direcory options e.g. -sil-output-dir with WMO or -ir-output-dir in single-threaded WMO. This aligns the command line options with the the behaviour with these supplementary files in an output file map. Also adds tests for the precedence rules of the supplementary SIL/IR files with output file map, command line options, including -save-temps and mixed scenarios.
rjmansfield
requested review from
DougGregor,
artemcm,
cachemeifyoucan,
compnerd and
owenv
as code owners
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generates module level paths when using the SIL/IR direcory options e.g. -sil-output-dir with WMO or -ir-output-dir in single-threaded WMO. This aligns the command line options with the the behaviour with these supplementary files in an output file map.
Also adds tests for the precedence rules of the supplementary SIL/IR files with output file map, command line options, including -save-temps and mixed scenarios.