Switch to lossy UTF8 decoding for dependency scanner diagnostic result strings#2080
Open
artemcm wants to merge 1 commit intoswiftlang:mainfrom
Open
Switch to lossy UTF8 decoding for dependency scanner diagnostic result strings#2080artemcm wants to merge 1 commit intoswiftlang:mainfrom
artemcm wants to merge 1 commit intoswiftlang:mainfrom
Conversation
…t strings The 'toSwiftString' code currently force-unwraps a 'String' initializer which attempts to decode the input buffer as valid UTF-8. We have seen a crash on this force-unwrap. This change switches 'toSwiftString' to use the Swift standard library's 'String(decoding:,as:)' instead of Foundation's 'String(data:,encoding:)'. The former returns a non-optional value which replaces non-UTF-8 characters with a Unicode replacement character, instead of failing and returning 'nil'. This will not only resolve the crash, but also result in us emitting these potentially-corrupted strings for the user to see. Resolves rdar://157486211
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
toSwiftStringcode currently force-unwraps aStringinitializer which attempts to decode the input buffer as valid UTF-8. We have seen a crash on this force-unwrap.This change switches
toSwiftStringto use the Swift standard library'sString(decoding:,as:)instead of Foundation'sString(data:,encoding:). The former returns a non-optional value which replaces non-UTF-8 characters with a Unicode replacement character, instead of failing and returningnil.This will not only resolve the crash, but also result in us emitting these potentially-corrupted strings for the user to see.
Resolves rdar://157486211