Narrow testSubprocessPlatformOptionsSupplementaryGroups() on Darwin#345
Narrow testSubprocessPlatformOptionsSupplementaryGroups() on Darwin#345broken-circle wants to merge 1 commit into
testSubprocessPlatformOptionsSupplementaryGroups() on Darwin#345Conversation
|
The Unix These tests were originally introduced in iCharlesHu/Subprocess/main@
I was leaning toward option 1. I'd open a draft PR initially to validate that the macOS runners allow passwordless Which approach would you most prefer? I don't think we should leave them skipped. I have the option 1 draft PR mostly ready, or I can get started with option 2, if it's likely such an addition would be accepted there. |
|
1 seems like a good idea if it's possible |
7dc99d9 to
3bf4f9e
Compare
|
I tried in #351, but passwordless |
`id -G` on Darwin doesn't report the groups, but they are applied: the prefork child aborts the spawn if `setgroups(2)` fails, so a successful spawn confirms the call returned `0` and the credential was set; only Darwin's `id -G` read-back omits it. Keep the membership assertion where `id -G` is faithful and asserts only spawn success on Darwin.
3bf4f9e to
b3bbfaa
Compare
|
Hmm, I was under the impression that only self-hosted macOS runners were available for the swiftlang org, but @shahmishal could confirm the details there for sure. |
testSubprocessPlatformOptionsSupplementaryGroups()fails on Darwin:id -Gon Darwin doesn't report the groups, but they are applied: the prefork child aborts the spawn ifsetgroups(2)fails, so a successful spawn confirms the call returned0and the credential was set; only Darwin'sid -Gread-back omits it. This PR keeps the membership assertion whereid -Gis faithful and asserts only spawn success on Darwin.