fix(gen_stub): spell PHP_INT_MIN constants with ZEND_LONG_MIN - #48
Merged
Merged
Conversation
getCExpr() emitted int class constants, property defaults and parameter defaults with strval(), so `const M = PHP_INT_MIN;` produced `ZVAL_LONG(&const_M_value, -9223372036854775808)`. C parses that as unary minus applied to the literal 9223372036854775808, which exceeds long long and is ill-formed, so the generated extension source does not compile. The expression path already handles this via genIntegerLiteral (ZEND_LONG_MIN); give the stub metadata path the same spelling. The float paths (17-digit round-trip, -0.0 sign, INF/NAN) were already fixed upstream in 2d81626; the new test pins those literals down together with the int boundary values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
const M = PHP_INT_MIN;(and property/parameter defaults with that value) made gen_stub emitZVAL_LONG(&v, -9223372036854775808)— an ill-formed C literal (9223372036854775808overflows long long before negation; clang warns, breaks under -Werror). The compiler's own genIntegerLiteral already spells thisZEND_LONG_MIN; getCExpr() now does the same.Test pins the exact emitted literals.
Part of the split of #39.