fix(parser): resolve PHP_INT_MAX/MIN folds case-sensitively with namespace rules - #49
Merged
Merged
Conversation
…space rules constantNumericValue() matched strtolower($name) with no namespace resolution, so two invalid folds happened: `namespace N; const PHP_INT_MAX = 5; PHP_INT_MAX + 1` folded to 9.22e18 where PHP resolves the namespaced constant and yields 6, and a lowercase `php_int_max` silently folded to the global value where PHP raises an undefined-constant Error. Resolve the fetched name the way parseConstFetch() does: a `use const` alias resolves to its target, a fully qualified name is global, an unqualified name inside a namespace participates in PHP's runtime fallback (Namespace\NAME can be defined before the fetch executes) and therefore never provably names the global, and the match is now case-sensitive. Only a provable global PHP_INT_MAX/PHP_INT_MIN folds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constant folder recognized
PHP_INT_MAX/PHP_INT_MINcase-insensitively and without namespace resolution:namespace N; const PHP_INT_MAX = 5; echo PHP_INT_MAX + 1;folded to9.2e18instead of reading the namespaced constant (Zend prints 6), and lowercasephp_int_maxsilently folded where Zend raises an undefined-constant Error.Resolution now mirrors parseConstFetch:
use constaliases honored, fully-qualified means global, unqualified-in-namespace falls back to the runtime lookup, and matching is case-sensitive.Verified against Zend 8.4.13; tests + phpt included.
Part of the split of #39.