fix(attribute): mark ClassConstFetch as lazy to resolve enum attribute args - #8
Closed
yuan-dian wants to merge 2 commits into
Closed
fix(attribute): mark ClassConstFetch as lazy to resolve enum attribute args#8yuan-dian wants to merge 2 commits into
yuan-dian wants to merge 2 commits into
Conversation
…e args ClassConstFetch expressions (e.g. Status::Active) in attribute arguments were not marked as lazy values, so the PHPX bridge stored the backing string value instead of calling the factory that resolves the enum case. Add ClassConstFetch to requiresLazyValue() so the lazy marker is set and the factory function is invoked at runtime via typephp_attribute_set_lazy_value_argument().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When a backed enum value is used as an attribute argument (e.g.
#[TableId(IdType::AUTO)]), the compiled binary stores the string backing value instead of the enum instance.Reproduction: