Add pointwise optimized mismatch calculation#191
Open
keefemitman wants to merge 6 commits into
Open
Conversation
Comment on lines
+375
to
+377
| for mode in include_modes: | ||
| wa_sliced_data[:, wa_sliced.index(*mode)] *= 0 | ||
| wb_sliced_data[:, wb_sliced.index(*mode)] *= 0 |
Member
There was a problem hiding this comment.
Isn't this the inverse of the mask you want? This is setting all modes in include_modes to vanish.
| raise ValueError(f"(t1, t2)=({t1}, {t2}) is not contained in wb.t.") | ||
| if wa.spin_weight != wb.spin_weight: | ||
| raise ValueError( | ||
| f"Spin weights must match, but got wa.spin_weight={wa.spin_weight} " f"and wb.spin_weight={wb.spin_weight}." |
Member
There was a problem hiding this comment.
Suggested change
| f"Spin weights must match, but got wa.spin_weight={wa.spin_weight} " f"and wb.spin_weight={wb.spin_weight}." | |
| f"Spin weights must match, but got {wa.spin_weight=} and {wb.spin_weight=}." |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 43.19% 42.18% -1.02%
==========================================
Files 85 85
Lines 6473 6650 +177
Branches 1066 1094 +28
==========================================
+ Hits 2796 2805 +9
- Misses 3423 3592 +169
+ Partials 254 253 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| wb_sliced_data = wb_sliced.data | ||
| for L in range(wa.ell_min, wa.ell_max + 1): | ||
| for M in range(-L, L + 1): | ||
| if not (L,M) in include_modes: |
Member
There was a problem hiding this comment.
I think stylistically we would prefer (L,M) not in include_modes, even though the result is the same
| "A `modes` argument was provided, but the input `wa` " | ||
| "and `wb` only have one dimension." | ||
| ) | ||
| raise ValueError("A `modes` argument was provided, but the input `wa` " "and `wb` only have one dimension.") |
Member
There was a problem hiding this comment.
This whitespace change looks funny...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the usual LVK mismatch calculation of sampling a series of points on the two sphere, then for each point optimizing over time, binary phase, and polarization to minimize the residual, and returning the maximal mismatch obtained across all of the sky points. @moble probably worth you looking at, but @duetosymmetry probably also of interested to you.
📚 Documentation preview 📚: https://sxs--191.org.readthedocs.build/en/191/