Skip to content

release: align desktop release versions#149

Open
fettpl wants to merge 2 commits into
sybil-solutions:mainfrom
fettpl:fix/release-version-alignment-148
Open

release: align desktop release versions#149
fettpl wants to merge 2 commits into
sybil-solutions:mainfrom
fettpl:fix/release-version-alignment-148

Conversation

@fettpl

@fettpl fettpl commented Jun 20, 2026

Copy link
Copy Markdown

Summary

  • Applies semantic-release's computed nextRelease.version to root and frontend package metadata in the release workspace.
  • Adds a tested scripts/apply-release-version.mjs helper so Electron Builder sees the GitHub release version.
  • Documents semantic-release as the stable desktop release version source of truth in AGENTS.md.

Context

Addresses #148 and supports the Homebrew-readiness umbrella in #140.

The release bot does not commit package-version bumps to protected main. Package metadata is updated only in the GitHub Actions workspace before later desktop packaging steps.

Rebase Resolution

  • Rebased onto Local Studio 2.0 at current main.
  • Preserved Node 22.19.0, the current git-hook installer, desktop staging command, and current check chain.
  • Preserved the deletion of the legacy publishing guide and kept release guidance in AGENTS.md.
  • Updated the release-version fixture to exercise 2.0.0 to 2.0.1.
  • Kept this PR limited to version alignment; macOS asset publishing remains in ci(release): publish macOS desktop assets #150.

Validation

  • npm run test:release-version (2 tests)
  • Release workflow YAML parse
  • Release configuration assertion for the @semantic-release/exec prepare command
  • git diff --check origin/main...HEAD
  • Mandatory pre-push npm --prefix frontend run check:quality gate

GitHub reports the PR as mergeable. The CI and Security runs for this head are action_required with no jobs created, pending maintainer approval; the requested @0xSero review is also pending.

AI Disclosure

AI assistance was used to inspect the release/versioning setup, implement and test the helper, resolve the rebase, and review the final diff. I reviewed the resulting code and command output before updating this PR.

@0xSero

0xSero commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Reviewed — the approach is right: exec prepareCmd in the prepare lifecycle, workspace-only version application, no commits to protected main, and the helper + tests look solid. This genuinely fixes the 0.2.x-vs-v1.x mismatch (#148) since electron-builder reads frontend/package.json.

It's now conflicting because main deleted CONTRIBUTING.md (docs consolidated into AGENTS.md/README.md) and the root check script changed (check:cli removed, package renamed to local-studio). Both are trivial to resolve on rebase — please move the release-process paragraph into AGENTS.md, and update the vllm-studio test fixtures to local-studio while you're there.

Happy to merge once rebased.

@fettpl

fettpl commented Jul 13, 2026

Copy link
Copy Markdown
Author

@0xSero requested rebase follow-up is complete in 402a5705.

  • Rebasing onto current main preserved the CONTRIBUTING.md deletion.
  • The release-version guidance now lives in AGENTS.md.
  • Root fixtures use local-studio.
  • The root check chain no longer reintroduces the removed check:cli command.
  • npm run test:release-version passes, and the mandatory pre-push frontend quality gate passed.

GitHub reports #149 mergeable and ready for your review. #150 is stacked on this rebased commit and should be merged after #149.

@fettpl
fettpl force-pushed the fix/release-version-alignment-148 branch from 402a570 to 3cdc9c3 Compare July 16, 2026 18:38
@fettpl

fettpl commented Jul 16, 2026

Copy link
Copy Markdown
Author

@0xSero conflicts are resolved and this branch is rebased onto current Local Studio 2.0 main at 3cdc9c30. GitHub reports the PR as mergeable; the mandatory pre-push frontend quality gate and targeted release-version validation are green. The CI and Security runs are action_required with no jobs created and need maintainer approval; your requested review is also pending.

@fettpl

fettpl commented Jul 17, 2026

Copy link
Copy Markdown
Author

@0xSero v2.0.0 confirms this PR’s contract: the release tag, updater metadata, and app bundle versions all report 2.0.0. No release-driven change is needed in #149; it remains the future semantic-release version-alignment path and is ready for review.

@fettpl
fettpl force-pushed the fix/release-version-alignment-148 branch from 3cdc9c3 to 8ce6839 Compare July 19, 2026 19:06
@fettpl

fettpl commented Jul 19, 2026

Copy link
Copy Markdown
Author

@0xSero Conflicts are resolved against current main (c6508d49). The PR is now mergeable at 8ce68398 and remains blocked only on review/workflow approval.

The rebase preserves the tested-revision workflow_run release trigger and semantic-release version preparation. Validation also exposed two failures already present on main: the frontend CI job lacked controller dependencies required by source-mapped contracts, and depcheck flagged the intentionally retained Playwright CLI after its scripts were removed. The minimal CI repair is included as 8ce68398.

Clean-worktree verification passed: npm --prefix frontend run check:quality, npm run check, release-version tests, pre-commit, and pre-push. The old frontend and integration test scripts no longer exist on current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants