fix(desktop): cross-platform dev scripts, Windows installer icon, per-name user-data dirs#209
Open
luminary19 wants to merge 2 commits into
Open
fix(desktop): cross-platform dev scripts, Windows installer icon, per-name user-data dirs#209luminary19 wants to merge 2 commits into
luminary19 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop dev scripts used POSIX inline env syntax (fails under cmd.exe), the
Windows installer shipped the default Electron icon, and renamed dev builds
shared the production user-data dir (cross-platform state-corruption
hazard). Scripts move to
cross-env,electron-builder.ymlgains a Windowsicon.ico, and the main process derives the user-data dir from the productname. Fixes #208.
Validation
npm --prefix frontend run typecheckandtypecheck:desktopclean;check:quality(lint + typecheck + build + depcheck) runs as the pre-push gate.cross-envis added as a devDependency (used by thedesktop:start:dev*scripts) and registered in
.depcheckrc.jsonso the depcheck gate stays green.Desktop packaging + the isolated per-name user-data dir were verified live on
Windows 11; macOS dev-mode commands are unchanged (
cross-envpasses the envthrough identically).
UI changes
Installer/app icon on Windows only.
Risks / rollout notes
cross-envis a devDependency addition (already whitelisted in depcheckignores by this change).