docs: Windows quick-start and a platform-aware doctor preflight#215
Open
luminary19 wants to merge 3 commits into
Open
docs: Windows quick-start and a platform-aware doctor preflight#215luminary19 wants to merge 3 commits into
luminary19 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
doctorpreflight platform-aware and adds a Windows quick-start tothe README.
scripts/doctor.sh:python3, thenpython, then thepylauncher (eachverified to actually run), instead of
python3only.uname -s(MINGW*/MSYS*/CYGWIN*) and, on Windows,prints the accurate GPU line — "CUDA llama.cpp serving available (vLLM/SGLang
require Linux)" — and defaults the models dir to
%USERPROFILE%\modelsinstead of
/models. The POSIX branch is byte-for-byte the previous behavior.README.md:%USERPROFILE%\modelsdefault.PowerShell 5.1
&&caveat, theservices/node_modulesjunction (no DeveloperMode needed), the llama.cpp prebuilt-CUDA install location, the vLLM/SGLang
Linux-only note, and the
LOCAL_STUDIO_CHROME_PATHbrowser override.Docs-and-preflight only; no runtime code changes. The Windows llama.cpp install
and browser behavior it documents ship in the wave-3 PRs (llamacpp-install,
browser-host).
Validation
bash -n scripts/doctor.shclean. Rannpm run doctorlive on Windows 11(Git Bash): all three new Windows branches fire correctly —
PASS python3 3.11.9 found,INFO nvidia-smi found — CUDA llama.cpp serving available (vLLM/SGLang require Linux),PASS models dir C:\Users\…\models exists and is writable— 7 pass / 0 fail. On Linux the script takes the unchangedPOSIX branch.
UI changes
None.
Risks / rollout notes
CI beyond the
doctorscript's own output.Fixes #214.