fix(downloads): prevent backpressure listener leaks#217
Open
lubluniky wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #216
Summary
drainorerrorsettles itBefore this change, 12 successful drain cycles left 12 stale
errorlisteners and emittedMaxListenersExceededWarning. The regression test now pins one lifecycle listener during the transfer and zero listeners after disposal.Validation
The pre-push frontend quality gate also passed, including the production Next.js build.
Environment note: a clean
npm cion currentmainhits the existing xterm beta peer-version conflict, so the root gate was run afternpm ci --legacy-peer-deps; the lockfile is unchanged.UI changes
None. This only changes the controller's model-download stream lifecycle.
Risks / rollout notes
Low. Download bytes, Range resume behavior, persistence, and progress updates are unchanged. The only behavioral difference is bounded listener lifetime and deterministic propagation of asynchronous writer failures. No migration or deployment step is required.