[Reliability] Make launch acceptance and cleanup atomic#243
Open
fettpl wants to merge 2 commits into
Open
Conversation
fettpl
force-pushed
the
p1/issue-226-atomic-launch-acceptance
branch
from
July 18, 2026 10:42
c4042e9 to
e2babd1
Compare
fettpl
marked this pull request as ready for review
July 18, 2026 10:43
Author
|
@0xSero This ready/non-draft fork PR now points to independently reviewed exact head f716b5d. Its focused launch suite, controller gates, full repository check, and intact pre-push quality/build hook passed. Current-head workflows are waiting at GitHub’s fork approval gate: CI run 29731261530 and Security run 29731261303. Please approve these runs when convenient. |
fettpl
force-pushed
the
p1/issue-226-atomic-launch-acceptance
branch
from
July 20, 2026 09:23
48945e4 to
f716b5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes launch admission, cancellation, and cleanup atomic by assigning every accepted launch an immutable attempt identity and requiring all state transitions to compare that identity.
Closes #226
Dependency
Depends on #244. The issue-specific implementation is a seven-file controller delta on top of that release-gating prerequisite.
Root cause
Launch admission used a check-then-set sequence: it observed idle state, awaited process discovery, and only then reserved the launch. Ownership was keyed by recipe ID, so a repeated attempt could replace cancellation state and stale cleanup could clear or cancel a successor.
Solution design
Deferredso stale finalization cannot release a successor.Acceptance criteria
Validation
f716b5d3413a365e7a3eeb775fdb918cf75b2a5d.npm --prefix frontend run check:quality: passed.npm run check: passed, including contracts, structure, frontend production build, and controller gates.git diff --checkpasses.Current
maindoes not definenpm run test:integrationor a genericnpm --prefix frontend run testscript, so those unavailable commands are not represented as passing.UI changes
None. The issue-specific delta is controller-only; no additional desktop rebuild is required beyond the already validated stacked prerequisite.
Risks and rollout
attempt_id; stale or unscoped cancellation is rejected rather than risking a successor.mainif GitHub does not remove the stacked prerequisite automatically.