[Bug] Unify the visible desktop browser and agent browser tools#254
Open
fettpl wants to merge 4 commits into
Open
[Bug] Unify the visible desktop browser and agent browser tools#254fettpl wants to merge 4 commits into
fettpl wants to merge 4 commits into
Conversation
Author
|
@0xSero CI and Security for the independently approved exact head |
fettpl
force-pushed
the
p1/issue-236-unified-browser-surface
branch
from
July 20, 2026 09:25
c996c84 to
a9457a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<webview>path with the same CDP screencast surface used by agent browser tools, so the visible pane and tool calls observe and control one page.file://access.Closes #236
Depends on #252, whose exact browser-network-policy commit is the base of this branch.
Root cause
The desktop rendered an Electron webview while agent browser tools controlled a separate managed Chromium page. An initial unification attempt also let older navigation requests mutate the shared host after newer intents and used an exact-URL latch that could suppress a legitimate redirect forever. The final implementation has one host-authoritative surface, ordered explicit mutations, and a poll-settlement barrier rather than URL equality.
Validation
npm --prefix frontend run check:qualitypassed.npm run checkpassed.a9457a041b9f50bd5da98f3c466ec2f904a8db4cwith no blocking findings.desktop:distcompleted successfully, including ZIP and DMG generation. Local signing was skipped because no valid trusted signing identity was available; release signing behavior is unchanged./Applications/Local Studio.appwas replaced, registered, and relaunched. Its persisted embedded port was 65002 and/api/desktop-healthreturned HTTP 200 withok:trueafter cleanup.UI changes
The desktop browser pane now renders the managed CDP screencast used by agent tools. Navigation and input remain visible in that same pane, and project files continue to open through the existing Files/canvas viewers rather than browser
file://access.Acceptance criteria
Risks / rollout notes
Workflow state
The exact-head fork workflows require maintainer approval before jobs can execute: