Remove redundant enclosing lock from BalanceCache - #18
Open
syjn99 wants to merge 1 commit into
Open
Conversation
The BalanceCache struct wraps hashicorp/golang-lru which already has internal locking. The external sync.RWMutex is redundant and adds unnecessary overhead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
syjn99
force-pushed
the
fix/remove-lru-lock-active-balance
branch
from
March 4, 2026 18:04
2b14546 to
28b3a08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync.RWMutexfromBalanceCachestruct inbeacon-chain/cache/active_balance.gohashicorp/golang-lrucache already provides internal thread-safe locking, making the external lock unnecessary overheadc.lock.Lock()/Unlock()/RLock()/RUnlock()calls fromClear(),AddTotalEffectiveBalance(), andGet()syncimportCloses OffchainLabs#13723
Test plan
gofmtandgoimportspassbazel build //beacon-chain/cache/...passesbazel test //beacon-chain/cache/...passes (2/2 tests pass, no regressions)🤖 Generated with Claude Code