Skip to content

git: migrate git{attributes,config,ignore}-mode to git-modes#15117

Merged
smile13241324 merged 1 commit intosyl20bnr:developfrom
lebensterben:gitmode-fix
Nov 2, 2021
Merged

git: migrate git{attributes,config,ignore}-mode to git-modes#15117
smile13241324 merged 1 commit intosyl20bnr:developfrom
lebensterben:gitmode-fix

Conversation

@lebensterben
Copy link
Copy Markdown
Contributor

@lebensterben lebensterben commented Oct 22, 2021

fixes #15111

@lebensterben lebensterben mentioned this pull request Oct 22, 2021
Closed
@eklitzke
Copy link
Copy Markdown
Contributor

eklitzke commented Oct 22, 2021 •
edited
Loading

I'm still getting this error when using your branch:

An error occurred while installing helm-gitignore (error: (error Package ‘gitignore-mode-1.1.0’ is unavailable))

@BenedictHW
Copy link
Copy Markdown
Contributor

BenedictHW commented Oct 22, 2021

Same findings here. I submitted a PR
jupl/helm-gitignore#6 against the upstream dependency
'helm-gitignore'. Other than that, I think we're good.

Cheers,

@eklitzke
Copy link
Copy Markdown
Contributor

eklitzke commented Oct 25, 2021

I think it would be reasonable to merge this as-is, since it's less broken then develop currently is. For now I just cherry-picked this change and added helm-gitignore to my dotspacemacs-excluded-packages.

I know that jupl/helm-gitignore#6 has only been open a few days, but since the helm-gitignore package hasn't been updated since 2017 we may need to be prepared for it being abandoned. I personally don't think the helm-gitignore functionality is that useful anyway.

@lebensterben
Copy link
Copy Markdown
Contributor Author

lebensterben commented Oct 25, 2021

then we can remove heml-gitignore until it's fixed

@BenedictHW
Copy link
Copy Markdown
Contributor

BenedictHW commented Oct 26, 2021

I've never used -- and I don't think I will use -- the functionality myself
either. I don't know about others. I'm slightly in favor of axing it as well.

It is a trivial feature/package that ought to be easy enough to fork and re-add
if it does break workflows.

@rogeric
Copy link
Copy Markdown

rogeric commented Oct 26, 2021

@lebensterben Seems another broken due to the git dependency.

"Error running timer ‘git-gutter:live-update’: (file-missing "Searching for program" "No such file or directory" "diff")"

@robbyoconnor
Copy link
Copy Markdown
Contributor

robbyoconnor commented Oct 26, 2021

I was about to fix this :)

eklitzke added a commit to eklitzke/spacemacs that referenced this pull request Oct 27, 2021
@eklitzke
Remove helm-gitignore from git layer.
54b9978 
Related to syl20bnr#15117, this removes the helm-gitignore from the git layer because it
hasn't been updated to use the new git-modes package. The helm-gitignore
functionality isn't particularly useful anyway, it's just a utility to help
generate .gitignore files.

This change can be reverted if the upstream helm-gitignore package is fixed and
people find the functionality it provides to be useful.
@eklitzke eklitzke mentioned this pull request Oct 27, 2021
Merged
@robbyoconnor
Copy link
Copy Markdown
Contributor

robbyoconnor commented Oct 28, 2021

https://melpa.org/#/git-modes

bhipple
bhipple approved these changes Oct 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@bhipple bhipple left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be really nice to get this in; every startup my emacs is hanging for ~30 seconds trying to find the 3 removed packages, since I cleared out my old melpa cache :)

@robbyoconnor
Copy link
Copy Markdown
Contributor

robbyoconnor commented Nov 2, 2021

Add the packages to your dotspacemacs-excluded-package list in your .spacemacs or ~/.spacemacs.d/init.el. This will fix things.

@robbyoconnor
Copy link
Copy Markdown
Contributor

robbyoconnor commented Nov 2, 2021

The other option is to merge this locally into your fork.

smile13241324
smile13241324 approved these changes Nov 2, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@smile13241324 smile13241324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smile13241324 smile13241324 merged commit f4f8ad8 into syl20bnr:develop Nov 2, 2021
smile13241324 pushed a commit that referenced this pull request Nov 2, 2021
@eklitzke @smile13241324
Remove helm-gitignore from git layer.
66e509f 
Related to #15117, this removes the helm-gitignore from the git layer because it
hasn't been updated to use the new git-modes package. The helm-gitignore
functionality isn't particularly useful anyway, it's just a utility to help
generate .gitignore files.

This change can be reverted if the upstream helm-gitignore package is fixed and
people find the functionality it provides to be useful.
@lebensterben lebensterben deleted the gitmode-fix branch January 15, 2022 02:23
eraad pushed a commit to datil/spacemacs that referenced this pull request Jun 10, 2022
@eklitzke @eraad
Remove helm-gitignore from git layer.
5f50979 
Related to syl20bnr#15117, this removes the helm-gitignore from the git layer because it
hasn't been updated to use the new git-modes package. The helm-gitignore
functionality isn't particularly useful anyway, it's just a utility to help
generate .gitignore files.

This change can be reverted if the upstream helm-gitignore package is fixed and
people find the functionality it provides to be useful.
2ynn pushed a commit to 2ynn/spacemacs that referenced this pull request Jun 22, 2022
@eklitzke @2ynn
Remove helm-gitignore from git layer.
db710cc 
Related to syl20bnr#15117, this removes the helm-gitignore from the git layer because it
hasn't been updated to use the new git-modes package. The helm-gitignore
functionality isn't particularly useful anyway, it's just a utility to help
generate .gitignore files.

This change can be reverted if the upstream helm-gitignore package is fixed and
people find the functionality it provides to be useful.
tarsius pushed a commit to emacsorphanage/helm-gitignore that referenced this pull request Mar 10, 2023
@BenedictHW @tarsius
Depend on git-modes instead of absorbed gitignore-mode
85c3406 
`gitignore-mode' is no longer distributed as a separate package.
It is now distributed as part of the `git-modes' package.  Depend
on the latter.

See melpa/melpa@cc3a0ce6c8a4a67b8a8d4b,
syl20bnr/spacemacs#15117
and jupl#6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smile13241324 smile13241324 smile13241324 approved these changes

+3 more reviewers

@eklitzke eklitzke eklitzke approved these changes

@robbyoconnor robbyoconnor robbyoconnor approved these changes

@bhipple bhipple bhipple approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Heads up: gitignore-mode and gitconfig-ode were moved to git-modes

7 participants

@lebensterben @eklitzke @BenedictHW @rogeric @robbyoconnor @bhipple @smile13241324