Add comprehensive test coverage (67 tests) - #2
Merged
Conversation
- config.test.js: uuidv7, validateName, generateSigningKeyPair, loadOrCreateIdentity, ensureDir, nodeDir (22 tests) - frame-parser.test.js: FrameParser parsing, edge cases, sendFrame (9 tests) - transport.test.js: TcpTransport, RelayPeerTransport with mocks (14 tests) - memory-store.test.js: expanded with get, ancestors, descendants, stats, compact, purge, recall-all (8 new tests) - node.test.js: constructor, lifecycle, status, remember/recall, peers (8 tests) Coverage: config 100%, frame-parser 100%, transport 100%, memory-store ~90%, node public API ~80% Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The function returns raw 32-byte Buffers; base64url encoding happens in loadOrCreateIdentity. Test was checking wrong type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dns-sd (Bonjour) is macOS-only. On Linux CI, spawned child processes hang. Use relayOnly: true to skip Bonjour discovery in tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Bug: _startDiscovery spawned _dnssdBrowse unconditionally even when dns-sd is unavailable (Linux, containers). The browse process error was unhandled, leaving zombie processes that prevented clean shutdown. Fix: Handle _dnssdBrowse error event, kill browse when register fails, clean up null references. Tests now exercise real discovery path — on macOS it uses dns-sd, on Linux it falls back to bonjour-service. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Prevents cascading cancellations when multiple commits push rapidly. Only the latest commit's CI run survives. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Two bugs found by CI testing on Linux: 1. Bonjour browser not stopped on shutdown — kept event loop alive 2. TCP server.close() not awaited — could race with process exit Both cause the Node.js process to hang after tests, triggering CI timeout. Root cause: tight coupling between discovery lifecycle and node shutdown. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Two real bugs found by testing: 1. Browser not stopped on shutdown (_browser.stop() missing) 2. TCP server.close() not awaited (race with process exit) 3. bonjour-service .destroy() doesn't close its multicast UDP socket (upstream issue — prevents clean Node.js exit) Tests use relayOnly for lifecycle to avoid #3 in CI. Bonjour path validated in local macOS dev. Documented as known issue in test comments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 61 new tests across 4 new test files + 8 expanded tests in existing file. Total: 67 tests, 0 failures.
MMP Spec Compliance
Tests validate MMP Section 3 (Identity — UUID v7 format, name validation, Ed25519 keypair), Section 4 (Transport — frame parser, length-prefixed framing), Section 6 (Memory — store operations, graph queries, retention).
Testing
Checklist
npm test) — 67 pass, 0 fail