[TypeScript] Migrate lib/config/*#1508
Merged
Merged
Conversation
Kocal
commented
Jun 30, 2026
Comment on lines
+15
to
+17
| // .js (not .ts): RuntimeConfig is exposed in this module's emitted .d.ts, and | ||
| // rewriteRelativeImportExtensions does NOT rewrite .ts -> .js inside .d.ts files | ||
| // (only in emitted .js). tsc still resolves .js -> the .ts source here. |
Member
Author
There was a problem hiding this comment.
When all files will be migrated to .ts, we should:
- modify all
.tsimports to.js - remove
allowImportingTsExtensionsandrewriteRelativeImportExtensionscompiler options - tweak ESLint configuration if necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1503