Fix issue incorrect paths for fonts. Add methods to Use relative paths#179
Fix issue incorrect paths for fonts. Add methods to Use relative paths#179nikrou wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Some comments I have after a quick look at your changes (one of them probably being related to the failing tests).
I would also add a test case for each method in test\index.js to be sure that the return this doesn't silently disappear later on.
As I said in #85 though, I'm not sure that's the right way to handle it. The file-loader seems to provide a useRelativePath option that could do the job (didn't have the time to test it, so I may be wrong).
| @@ -0,0 +1,9 @@ | |||
| $font-path: '../fonts'; | |||
There was a problem hiding this comment.
This file should probably be in the fixture/css folder.
| return this; | ||
| }, | ||
|
|
||
| setFontsPublicPath(publicPath) { |
There was a problem hiding this comment.
I'd add at least a small comment here with some use cases.
| return this; | ||
| }, | ||
|
|
||
| setImagesPublicPath(publicPath) { |
There was a problem hiding this comment.
Missing comment for that one too.
There was a problem hiding this comment.
By the way, do we really need two methods? is there a use case in which we would only call one of them or call them with different values?
|
Yea, we need to do some playing with this. I'm also interested in |
|
@weaverryan any news on relative paths? |
|
Hello, I also need relative paths for fonts. Any news ? |
5 participants
The idea is to allow to use relative path for fonts and/or images.