Rename protocol to "Synadia Agent Protocol for NATS"#103
Conversation
Mechanical rename across READMEs, CHANGELOGs, package descriptions, and source-file headers/docstrings. No behaviour change — protocol wire shape, version (0.3), package names, and GitHub repo URLs are all unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Claude finished @M64GitHub's task in 2m 35s —— View job PR Review
Summary: Pure prose rename, mechanically consistent. No behaviour change, no wire shape change, no API surface change. The test plan's One phrasing nit worth fixing before merge:
The double "for" ("for NATS bridge for vercel-labs") is awkward. Consider:
or just restructure to sidestep the collision:
Everything else looks correct:
|
![synadia-claude-reviewer[bot]](https://avatars.githubusercontent.com/u/132956691?s=60&v=4){kind=small}
| # `@synadia-ai/open-agent` | ||
|
|
||
| A NATS Agent Protocol bridge for | ||
| A Synadia Agent Protocol for NATS bridge for |
There was a problem hiding this comment.
Double "for" reads awkwardly: "for NATS bridge for vercel-labs". Consider restructuring:
| A Synadia Agent Protocol for NATS bridge for | |
| A bridge implementing the **Synadia Agent Protocol for NATS** for |
- client-sdk/python/src/synadia_ai/agents/errors.py: split ProtocolError docstring to fit the 100-char line limit. - agents/open-agent/README.md: reword "Synadia Agent Protocol for NATS bridge for vercel-labs/open-agents" to avoid the awkward double "for" (per reviewer suggestion). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@claude - please review again, we have fixed the issues ... |
|
Claude finished @M64GitHub's task in 58s —— View job Re-review
The previous nit has been addressed.
That's the exact restructure suggested in the prior review — clean, no more double "for". Everything else remains correct:
This PR is ready to merge. |
* release prep: 0.5.x patch wave for protocol rename Bumps six @synadia-ai/* packages to refresh their npmjs.com descriptions after PR #103's protocol-name sweep. No API, wire shape, or protocol version (0.3) changes ship here. Versions: - @synadia-ai/agents: 0.5.0 → 0.5.1 - @synadia-ai/agent-service: 0.5.1 → 0.5.2 (also rolls in §6.4 leading-ack work currently in [Unreleased]) - @synadia-ai/nats-channel (openclaw): 0.5.5 → 0.5.6 - @synadia-ai/nats-pi-channel: 0.5.2 → 0.5.3 - @synadia-ai/nats-pi-headless: 0.5.3 → 0.5.4 - @synadia-ai/nats-claude-code-headless: 0.5.3 → 0.5.4 file: links are preserved (main's default dev state). The publish ladder runs `./devtools/devmode.sh off` locally before publish, then `on` after — see README-DEV.md §"Releasing the SDKs". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(agents/{pi,openclaw}): rename stale "nats-agent-protocol" keyword Per PR reviewer: the rename sweep missed the kebab-case keyword in these two package.json files. Replace with "synadia-agent-protocol" so npm discoverability matches the new protocol name. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 participant
Summary
0.3), published package names (@synadia-ai/agents,synadia-ai-agents, etc.), and thesynadia-ai/nats-agent-sdk-docsGitHub URL slug are all unchanged.Test plan
git grep "NATS Agent Protocol"returns nothingclient-sdk-typescript.yml,agent-sdk-typescript.yml) green — prose-only diff, no code paths touchedclient-sdk-python.yml,client-sdk-python-agent-service.yml) green🤖 Generated with Claude Code